search

python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 601 forks source link

No error message for SolrCollector if no cores are present #661

Open aratik711 opened 7 years ago

aratik711 commented 7 years ago

When ever we add the solrcollector for solr 5.5.4 or 6.6.0 in diamond, the diamond service starts with out any message on the terminal or logs. But the solr server metrics are not visible in the graphite dashboard. No error message is displayed in the logs. This is because no cores are present in the solr server. If we add one then the metrics start to load in the graphite dashboard. Diamond version used is: 4.0.809 Graphite version: 0.9.0 The solrcollector should display a proper message.

aratik711 commented 7 years ago

Can you create a branch for me. I would like to contribute.

shortdudey123 commented 2 years ago

Feel free to submit a PR.