search

python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 601 forks source link

Fixing testtsdb.py unit test #671

Open ajkumarnv opened 7 years ago

ajkumarnv commented 7 years ago

Some tests for testtsdb.py are failing occasionally as we are comparing the mock_urlopen call args against a string . json.dumps behavior is sometimes unpredictable so string comparison at times fails. Changed to code the do json.load from the args and compare it against the list rather than string

ajkumarnv commented 7 years ago

Some tests for testtsdb.py are failing occasionally as we are comparing the mock_urlopen call args against a string . json.dumps behavior is sometimes unpredictable so string comparison at times fails. Changed to code the do json.load from the args and compare it against the list rather than string

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 24.667% when pulling 404ef1098338d0c837560d5be8680c8751290414 on ajkumarnv:master into f2bece462577a7c557be8a9f90f6b9340c3db571 on python-diamond:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 24.667% when pulling 404ef1098338d0c837560d5be8680c8751290414 on ajkumarnv:master into f2bece462577a7c557be8a9f90f6b9340c3db571 on python-diamond:master.