Remove unsupported Python 2.4 and 2.5 code - Githubissues

python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.

http://diamond.readthedocs.org/

MIT License

1.74k stars 601 forks source link

Remove unsupported Python 2.4 and 2.5 code #682

Closed hugovk closed 6 years ago

coveralls commented 6 years ago

Coverage remained the same at 24.667% when pulling 2d605606b620ccd1c5eda843fc2131f10b10c7da on hugovk:patch-1 into f2bece462577a7c557be8a9f90f6b9340c3db571 on python-diamond:master.

coveralls commented 6 years ago

Coverage remained the same at 24.667% when pulling 2d605606b620ccd1c5eda843fc2131f10b10c7da on hugovk:patch-1 into f2bece462577a7c557be8a9f90f6b9340c3db571 on python-diamond:master.

coveralls commented 6 years ago

Coverage increased (+0.04%) to 24.702% when pulling c115489ad1a100ad30e5b748083956e44c49bf1e on hugovk:patch-1 into f2bece462577a7c557be8a9f90f6b9340c3db571 on python-diamond:master.

coveralls commented 6 years ago

Coverage increased (+0.04%) to 24.702% when pulling 6d9e302d1b69f1176fcd48d3ebcca77f6c4a263e on hugovk:patch-1 into f2bece462577a7c557be8a9f90f6b9340c3db571 on python-diamond:master.

coveralls commented 6 years ago

Coverage increased (+0.04%) to 24.702% when pulling 6d9e302d1b69f1176fcd48d3ebcca77f6c4a263e on hugovk:patch-1 into f2bece462577a7c557be8a9f90f6b9340c3db571 on python-diamond:master.

coveralls commented 6 years ago

Coverage increased (+0.04%) to 24.702% when pulling 1b950b909490b34398d557938722e9bd4b3f07af on hugovk:patch-1 into f2bece462577a7c557be8a9f90f6b9340c3db571 on python-diamond:master.

hugovk commented 6 years ago

Here's the pip installs for diamond from PyPI for the last month:

$ pypinfo --percent --pip diamond pyversion
python_version percent download_count
-------------- ------- --------------
2.7              98.0%         27,185
2.6               1.8%            509
3.6               0.1%             22
3.5               0.0%              8
3.4               0.0%              3

hugovk commented 6 years ago

@shortdudey123 Hello, any thoughts on this PR? Thanks!