search

python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 601 forks source link

MongoDB collector splits logically atomic metric key components #697

Closed demonix closed 2 years ago

demonix commented 6 years ago

Hi! There was an issue #547, where @bdelbosc notices, that mongo db metrics contains spaces and fixes that. But at the same time he replaced dashes with dots. That's strange because a lot of metric names contain dashes and logically they must be written as single element in metric key. We also have dashes in collection and index names, so writing graphite functions on top of these metrics is hard.

So I think, replacing dashes with dots completly wrong. That's easily fixable, but fixing this is breaking change. What do you think?

DStape commented 6 years ago

Hi @demonix,

This problem can be solved by adding a new config option to the MongoDB collector that allows the user to specify what delimiter to use. Is this something you'd be able to provide? Thanks.

demonix commented 6 years ago

Hi! I'm not a python developer, so I just added proposed functionality, without writing any tests, sorry :(

shortdudey123 commented 2 years ago

Closed by #706