search

python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 601 forks source link

Build deb issue on Ubuntu 16.04 #711

Open KlavsKlavsen opened 6 years ago

KlavsKlavsen commented 6 years ago

make deb (on latest git master), gives me this:

E: diamond changes: bad-distribution-in-changes-file unstable
W: diamond source: ancient-standards-version 3.9.1 (current is 3.9.7)
W: diamond: latest-debian-changelog-entry-without-new-version
W: diamond: maintainer-script-needs-depends-on-adduser postinst
W: diamond: maintainer-script-empty preinst
Finished running lintian.

and contents of the built package:

$ dpkg --contents build/diamond_4.0.832_all.deb 
drwxr-xr-x root/root         0 2018-06-26 13:05 ./
drwxr-xr-x root/root         0 2018-06-26 13:05 ./var/
drwxr-xr-x root/root         0 2018-06-26 13:05 ./var/log/
drwxr-xr-x root/root         0 2018-06-26 13:05 ./var/log/diamond/
drwxr-xr-x root/root         0 2018-06-26 13:05 ./etc/
drwxr-xr-x root/root         0 2018-06-26 13:05 ./etc/default/
-rw-r--r-- root/root       299 2017-04-18 11:08 ./etc/default/diamond
drwxr-xr-x root/root         0 2018-06-26 13:05 ./etc/diamond/
drwxr-xr-x root/root         0 2018-06-26 13:05 ./etc/diamond/collectors/
drwxr-xr-x root/root         0 2018-06-26 13:05 ./etc/init.d/
-rwxr-xr-x root/root      4384 2017-04-18 11:08 ./etc/init.d/diamond
drwxr-xr-x root/root         0 2018-06-26 13:05 ./etc/init/
-rw-r--r-- root/root       964 2017-04-18 11:08 ./etc/init/diamond.conf
drwxr-xr-x root/root         0 2018-06-26 13:05 ./usr/
drwxr-xr-x root/root         0 2018-06-26 13:05 ./usr/share/
drwxr-xr-x root/root         0 2018-06-26 13:05 ./usr/share/doc/
drwxr-xr-x root/root         0 2018-06-26 13:05 ./usr/share/doc/diamond/
-rw-r--r-- root/root      1334 2017-04-18 11:08 ./usr/share/doc/diamond/copyright
-rw-r--r-- root/root       514 2018-06-26 13:05 ./usr/share/doc/diamond/changelog.gz

Its missing all the rest.. it worked fine a few months ago.

KlavsKlavsen commented 6 years ago

According to a test done using git bisect: 0f3eb04327d6d3ed5e53a9967d6c9d2c09714a47 is the first bad commit

oovs commented 5 years ago

Its missing all the rest.. it worked fine a few months ago.

Faced the same issue, tried various releases: v3.4, v4.0.515 using Debian 9

shortdudey123 commented 1 year ago

I don't see anything in the commit mentioned above that would cause a build issue.