python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 602 forks source link

httpd collector doesn't support SSL / TLS #722

Open falkenbt opened 5 years ago

falkenbt commented 5 years ago

due to the usage of httplib.HTTPConnection the metrics collections fails silently if an https url is provided, which causes quite some debugging effort. The error logging needs to be improved for this case and SSL support could be added by using httplib.HTTPSConnection. I was about to send a PR to support https but I consider my quick fix not very secure as it trusts any certificates, which should be at least configurable. If anyone really requires this, I can give it a shot once I free up some time (sorry), or someone else tackles this.

shortdudey123 commented 2 years ago

go ahead and submit a PR.