search

python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 602 forks source link

delete = False in [[FilesCollector]] config file is delete = 'False', so it is True #724

Closed connexion2000 closed 2 years ago

connexion2000 commented 5 years ago

I noticed that any boolean value specified in config file and that is specific to any collector isn't handled correctly. It doesn't use str_to_bool() method nad is always string internally, so it is always True.

shortdudey123 commented 2 years ago

For the files collector you are correct. However since the default is a boolean False, as long as you do not specify it in the config, you avoid this. Feel free to submit a PR if you wish to fix this.

Closing . . .