search

python-diamond / Diamond

Diamond is a python daemon that collects system metrics and publishes them to Graphite (and others). It is capable of collecting cpu, memory, network, i/o, load and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.
http://diamond.readthedocs.org/
MIT License
1.74k stars 602 forks source link

collect_without_dimension not in latest release #758

Closed Jackleberry closed 2 years ago

Jackleberry commented 2 years ago

I'd like to use the collect_without_dimension option when collecting varnish metrics with the cloudwatch handler. I see it in the code base but not in the latest release even though the code was added before the release date. 

self.valid_config = ('region', 'collector', 'metric', 'namespace',
                             'name', 'unit', 'collect_by_instance',
                             'collect_without_dimension')

https://github.com/python-diamond/Diamond/blob/master/src/diamond/handler/cloudwatch.py#L88

Would it be possible to create a new release that includes these changes?

shortdudey123 commented 2 years ago

Use #709 to track a new release.