Add logo

[iakovleva]

Implements #17.

[sirex]

I like the logo, but could you also add favicon?

[sirex]

And, when creating pull requests and even in commit messages always reference original source of information that was cause creation of pull request. Currently I added reference myself.

[iakovleva]

Where favicon.ico should be saved? I found these options:

• it should be in the main root then the browser will automatically find it
• it should be in the static directory and there should be a link to the image in the base template
• or add a redirect in urls.py. Which one is correct?

[sirex]

Second. Add it to pylab/website/static/img/favicon.png and add <link rel="icon" type="image/png" href="{% static "img/favicon.png" %}">, the image should be 16x16 pixels size.

Also, please merge html-linter to your branch and make sure that tests pass.

[sirex]

http://www.w3.org/2005/10/howto-favicon

[sirex]

And one more question, maybe you have an SVG format of logo? If yes, then please add it to /design folder. Original vector image could be used later if we would want to produce other images in different sizes.

[iakovleva]

I changed logo styles to bootstrap but still I need to overwrite one setting (padding-top) in main.scss.

[sirex]

It is OK to add extra styling if bootstrap styles does not provide what you need.

I reviewed your pull request and found following issues:

1. Merge master into your branch, because your branch and master have conflicts.
2. Could you replace old pylab/website/static/img/pylab_logo.svg with you new version of logo in SVG format?
3. Your favicon.ico is not transparent.

[sirex]

Are you sure, that you wanted to close this pull request? I still see that most of the issues mentioned in comments are not fixed.

[iakovleva]

No, I did it occasionally. Can I reopen it somehow?

[sirex]

Just continue to commit to same branch, and github will offer you to create new pull request. Merge from logo to master cannot be undone.

Also, please do not commit or merge directly to master yourself. Only well tested and reviewed code can go to master.

[sirex]

Also, before continuing to commit to your logo branch, merge from master. You can merge from master using this command:

$ git checkout logo
$ git fetch
$ git merge origin/master
$ git push origin logo