search

python-dirbtuves / website

Python dirbtuvės project web site.
GNU Affero General Public License v3.0
2 stars 0 forks source link

Add "terms of service" checkbox #35

Open niekas opened 9 years ago

niekas commented 9 years ago

Connects to #20.

niekas commented 9 years ago

pylab.lt/terms/ page is not added yet. I'll create it based on google terms of service.

sirex commented 9 years ago

According to https://tosdr.org/ Google TOS is rated as Class C.

niekas commented 9 years ago

Nice page, combination of wikipedia and duckduckgo terms seems fair.

sirex commented 9 years ago

I guess duckduckgo is more about searching the web and wikipedia is more similar to pylab - people create content. So maybe instead of writing our own TOS, we could add link to Wikipedia TOS and add tosdr.org badge?

I guess to write a good TOS you have to be a lawyer.

sirex commented 9 years ago

Also try to not forget to add references to original source of information to pull request description (same applies to commit messages and tasks). In this case, original source of information is #20.

When commits, pull requests and tasks have references between them it is easier to find out what is going on. And github implements referencing different types of content very well.

sirex commented 9 years ago

Since you want to enforce terms of service, I think a middleware should be created in order to check if registered users accepted terms and conditions. If TOS where not accepted, middleware should always redirect user to TOS form.

sirex commented 9 years ago

Just wanted to let you know, that I can't approve this pull request, while link to terms and conditions does not work. At least create empty page with some TODO note in it.