search

python-discord / api

A FastAPI-based service that allows our services to communicatie with our database.
MIT License
10 stars 1 forks source link

Use .gitattributes to normalise line endings on check-in #2

Closed MarkKoz closed 3 years ago

MarkKoz commented 3 years ago

Remove the mixed line endings pre-commit hook because it is obsolete.

Relying on git to handle line endings means contributors have more flexibility with which line endings they want to use on check-out. The settings in .gitattributes only impose which line endings will be used upon check-in (LF), which should not impact local development; git will still respect the core.eol and core.autocrlf settings.

jchristgit commented 3 years ago

@MarkKoz, could you resolve conflicts here?

jb3 commented 3 years ago

Presumably the only conflict here is that .pre-commit-config.yaml was removed, I'll solve that quickly so we can get this in.

jchristgit commented 3 years ago

Excellent Joe, thank you

Am 10.07.2021 um 22:00 schrieb Joe Banks @.***>:

 Merged #2 into main.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.