Migrate reminder endpoints over from site, set up the testing suite

python-discord / api

A FastAPI-based service that allows our services to communicatie with our database.

MIT License

10 stars 1 forks source link

Closed D0rs4n closed 2 years ago

D0rs4n commented 2 years ago

Closes #22 Closes #31

This PR adds substantial pytest fixtures that can be used in the future. (More about that topic)
It also introduces changes in the linting-testing workflow:
- Add a test database to the workflow
Migrate reminders endpoint
- Now, using Async SQLAlchemy and 2.0 syntax.
Furthermore, Database enhancements have been implemented.
Introduce a new task to run tests inside docker. (See the updated README)

D0rs4n commented 2 years ago

LGTM! Maybe a few more places that could use more comments/explanation but otherwise it looks good to me

Thank you for the review, I've addressed a few changes regarding code consistency, and comments.

jchristgit commented 2 years ago

Closing this in coordination with Joe per us sunsetting this project.