search

python-discord / bot

The community bot for the Python Discord community
https://pythondiscord.com
MIT License
1.34k stars 664 forks source link

Remove or update code snippets on message edit #1802

Open bast0006 opened 3 years ago

bast0006 commented 3 years ago

At the moment, posting a link to github causes the bot to respond with a manually performed codeblock snippet of the contents linked. However, if the user edits their message to change the link, the contents of the embed do not change, and the user has to re-send their message to get updated contents.

We've previously implemented similar behavior for the Eval cog, with a refresh reaction. However, in this case, because the response is automatic and not derived directly from user interaction I think it makes sense to automatically keep the contents "up to date" with the origin message. If the link is edited, we edit our message, or if the link is removed, we remove our message.

We should probably still keep the trashcan reaction so users can delete the response independently of this.

wookie184 commented 4 months ago

This seems fine to me, though i'm not 100% sure it's worth the added complexity for a fairly rare case. I don't mind too much either way so if someone else vouches for this being a useful feature I think it would be ok to add.