search

python-discord / bot

The community bot for the Python Discord community
https://pythondiscord.com
MIT License
1.35k stars 667 forks source link

Add Embed detection for user messages for posting in mod alerts. #239

Closed scragly closed 5 years ago

scragly commented 5 years ago

Embeds can only be legitimately posted by webhooks and bot accounts.

If a user account sends an embed, either they're using scripts on their own account (selfbot) or they're using an unofficial client or tools that enable posting the embed data. Both of these are against Discord TOS, and as such require us to give notice to the user and a reminder of the rules.

Thankfully, it's really easy to implement this check, so would be suitable as a quick addition or a first contribution.

sco1 commented 5 years ago

I'm guessing the best place for this to fit would be in the filters cog?

SebastiaanZ commented 5 years ago

I think so, too, since messages are checked there anyway.

I can look into this tomorrow, if you weren't already, @sco1. I think this is another issue that will help me get comfortable with the bot.

sco1 commented 5 years ago

Have at it, just note that #251 makes some changes to the filters cog.

SebastiaanZ commented 5 years ago

Thanks, I was just looking at it.

vdkotian commented 5 years ago

Is this issue still open, coz I am looking forward to contributing.

scragly commented 5 years ago

The issue is open, as it's not resolved. However, it's already assigned to @SebastiaanZ so he's working on it currently.

Within issues, you can check if they've been assigned already to see if someone has started working on it in the Assignees section on the right side of the Issue page.