search

python-discord / bot

The community bot for the Python Discord community
https://pythondiscord.com
MIT License
1.34k stars 663 forks source link

Removal of Voice Verified role not logged when using `!tvmute` #2835

Open minalike opened 9 months ago

minalike commented 9 months ago

I noticed that when using the bot command !tvmute the removal of the Voice Verified role (if the user currently has it) is not logged to #user-log.

Example and repro in mod channel: https://ptb.discord.com/channels/267624335836053506/305126844661760000/1181339754667716649 https://ptb.discord.com/channels/267624335836053506/528976905546760203/1181337088562561166

ChrisLovering commented 9 months ago

This behaviour seems to be on purpose, and caused by this LoC https://github.com/python-discord/bot/blob/main/bot/exts/moderation/infraction/infractions.py#L536

If it's decided that this should now be logged, then that line is the one to remove.

minalike commented 9 months ago

I guess we have history in the code base of intentionally ignoring logs for voice verification-related events (https://github.com/python-discord/bot/issues/2076). I'd be in favor of not ignoring.

ChrisLovering commented 9 months ago

It's used in a few places, can see them all here https://github.com/search?q=repo%3Apython-discord%2Fbot+.ignore%28&type=code

wookie184 commented 5 months ago

The main benefit of ignores I can think of is when just searching for a user ID to try and get an overview of their actions - ignoring events which already have matching logs makes the result a bit easier to read through.

That said, if there's a use case where having the events would be useful I'd have no problem with adding them back in this case.