search

python-discord / django-crispy-bulma

Django application to add 'django-crispy-forms' layout objects for Bulma.io
MIT License
25 stars 9 forks source link

Useless classes? #13

Closed lemonsaurus closed 5 years ago

lemonsaurus commented 5 years ago

This fork implements a number of the classes that CrispyForms uses for its Layout, stuff like Field, Div and HTML. This appears to serve no real purpose - the official docs make no mention of it in https://django-crispy-forms.readthedocs.io/en/latest/template_packs.html, and I've just tested using the objects that come with Crispy itself and can see absolutely no difference

We should investigate this a little closer, but from what I can tell the classes serve absolutely no purpose. I think the fork has just pulled in classes from crispyforms in an attempt to make this package replace crispyforms, but that's a fairly misguided approach, and we should instead make a package that just adds the extra templates needed instead of trying to replace the package altogether.

lemonsaurus commented 5 years ago

This has been cleaned up - some classes do need minor changes, others are left unchanged.