Add support for Django 3.0

python-discord / django-crispy-bulma

Django application to add 'django-crispy-forms' layout objects for Bulma.io

MIT License

25 stars 9 forks source link

Add support for Django 3.0 #32

Closed MarkKoz closed 4 years ago

MarkKoz commented 4 years ago

django-crispy-forms has to be at least version 1.8 for Django 3.0 support, but I pinned it to 1.9 because it seems there were some import issues and deprecation warnings fixed in 1.9.

I haven't extensively tested this and don't really know how, so this has to wait for #31.

keans commented 4 years ago

I just tried to use the module with Django 3.0 and I noticed that the email input is not working as expected. It gets rendered to

<input type="email" name="email" maxlength="254" class="emailinput" id="id_email">

Though on the bulma webpage the CSS-class is solely "input". Could someone please check this?

Besides, django-crispy-bulma 0.3 seems not to be on pipy is the intentionally?

MarkKoz commented 4 years ago

@keans we can keep track of that problem in #31. Regarding version 0.3, it's not on PyPI because our release pipeline is currently broken. We are working on fixing it.