Add all accepted mail domains to SRS exclude configuration

[jb3]

We don't want to rewrite the envelopes of mail that is from a valid domain of our mailserver (e.g. pydis.com or int.pydis.wtf), but by default PostSRSD will rewrite anything that is not the mydomain configuration variable of Postfix (which is just set to pydis.wtf for us).

This change updates the environment defaults for PostSRSD to ensure that we don't change any envelopes that don't need to be changed, as well as ensuring that to end mailservers the DKIM and SPF checks are made against the actual domain (e.g. int.pydis.wtf) instead of the rewritten envelope.

[jchristgit]

Banks shoots, Banks Scores!

[jb3]

We should probably also add role::postfix to the handlers

Hmmm, we don't for other ones.

I believe the reason is that if we want to use a role as a dependency then adding tags onto it stops the handlers running properely if the handlers that have been notified are from a dependency that's not been tagged?

[jchristgit]

I believe the reason is that if we want to use a role as a dependency then adding tags onto it stops the handlers running properely if the handlers that have been notified are from a dependency that's not been tagged?

Isn't that already the case without any tags at all?

[jb3]

Hmm, well they run right now without tags, and of course run with tags, and they'll only ever run if called from a task which does have a tag.

[jchristgit]

On Tue, Sep 03, 2024 at 02:34:16AM -0700, Joe Banks wrote:

Hmm, well they run right now without tags, and of course run with tags, and they'll only ever run if called from a task which does have a tag.

Imagine you're a little kid, and you wait for a picture that you've been promised to get all day. You're really looking forward to this picture.
After waiting all day long, and hoping to finally receive the picture, you receive it and take a look. The picture consists of grass. Flat, green, grass. Uniformly cut with no deviations. It looks almost surreal. No sky in sight. No butterfly in sight. Monotonous, empty, grass.

That's what your comment is.

I have no idea which useful information regarding the problem at hand your response is actually giving me. For all I know, you've briefly elaborated the functionality of Ansible for me, thank you very much. But it did not contribute anything meaningful to the actual discussion.

Imagine you're in a desert walking along in the sand when all of the sudden you look down, and you see a tortoise. It's crawling toward you.

You reach down, you flip the tortoise over on its back.

The tortoise lays on its back, its belly baking in the hot sun, beating its legs trying to turn itself over, but it can’t, not without your help.

But you're not helping. Why is that?

It's for the same reason your comment is not helping, Joe. If I used the time I took to read your comment and write you a reply on why it's such pure and utter nonsense to do something else, perhaps we would now have tags on the handlers. Or perhaps we wouldn't.

Yes, Joe, perhaps, because,

well they run right now without tags

because they run without tags, perhaps, Joe, perhaps, we should just leave it as is, but perhaps, in another world, in a parallel universe, your comment would have carried even an ink of value.

[github-actions[bot]]

Thanks!