Make date formats consistent for `.github` embeds

python-discord / sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development.

MIT License

242 stars 239 forks source link

Make date formats consistent for `.github` embeds #1093

Open minalike opened 2 years ago

minalike commented 2 years ago

Description

Some dates are mm/dd/yyyy and others are dd/mm/yyyy. Make this consistent one way or another. Perhaps use localized timestamps since we have that option now instead of using the embed footers.
Nitpick: I think "minalike's GitHub profile info" should instead read: "minalike's GitHub Profile" (no backticks, proper casing)
Nitpick: The usage of a large thumbnail in the user embed versus a small icon for the repo embed is weird. I think I prefer the small icon. (Edit: on second thought, the user command is to feature the user and the repo command features the repository, not the repository owner. Still, my preference is the smaller icon for both).

Would you like to implement a fix?

[ ] I'd like to implement the bug fix
[x] Anyone can implement the bug fix

Comments and suggestions welcome.

wookie184 commented 1 year ago

I think the first one (Account created at) is a localised embed timestamp (shows dd/mm/yyyy for me), whereas the second one isn't, as localized timestamps in embed footers are very limited. I don't really have a preference on how to fix this inconsistency.

I agree with your second point on changing the title wording/formatting.

I don't really mind the icons being different. I quite like the bigger icon on the user command.

Ibrahim2750mi commented 1 year ago

If the status gets approved can I be assigned this issue?

wookie184 commented 1 year ago

If the status gets approved can I be assigned this issue?

There's still not really a conclusion on what should be changed for each part (apart from the second part).

Ibrahim2750mi commented 1 year ago

@wookie184 For the first part I think these lines are concerned

We could use either dd/mm/yyyy or mm/dd/yyyy for both.

Don't know about the third part, I think its better the way its now.

wookie184 commented 1 year ago

@wookie184 For the first part I think these lines are concerned

https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/utilities/githubinfo.py#L350-L351

https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/utilities/githubinfo.py#L264

We could use either dd/mm/yyyy or mm/dd/yyyy for both.

I would be happy with using dd/mm/yyyy for both although others may prefer using timestamps not in the footer so it's localised (CC @minalike?), i'm not too sure how that would look, although I'd also be happy with that.

minalike commented 1 year ago

Yeah I think it would be nice to move them out of the footer so we can use localized timestamps.