python-discord / sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development.
MIT License
244 stars 240 forks source link

Fix minesweeper command #1498

Closed wookie184 closed 8 months ago

wookie184 commented 8 months ago

Allowing a command in DMs needs to be done explicitly now, and we have not done that. I’ll be closing this issue.

We did kind of break minesweeper because it uses a command in DMs instead of just a message like battleship. We could either do what we do in battleship and have it listen to messages not commands, or we move it onto the server and delete the invocation to reduce spam. That can be tracked in a separate issue though.

Originally posted by @HassanAbouelela in https://github.com/python-discord/sir-lancebot/issues/581#issuecomment-1007380223

The minesweeper command doesn't currently work as the reveal commands only work in DM, but commands in DM are blocked.

We should either: 1) Allow the command. 2) Make the revealing and flagging message based using an on_message listener or something like that. 3) make it so messages should be sent on the server.

The argument against having the messages on the server is that there would be a lot of messages sent.

wookie184 commented 8 months ago

duplicate of https://github.com/python-discord/sir-lancebot/issues/1003