search

python-discord / sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development.
MIT License
240 stars 240 forks source link

[Feature Request] .games Command #354

Closed ks129 closed 4 years ago

ks129 commented 4 years ago

Description

There should .games command where you must provide genre to get random games from this genre (like my added .movies command) and also have following subcommands:

Reasoning

I'd like to see this in SeasonalBot, and there is already something like this in Halloween Season, so this mean other peoples want this too.

Proposed Implementation

Would you like to implement this yourself?

sco1 commented 4 years ago

What is the proposed API for this?

Is this intended to be a replacement for the existing cog (Merged by #258)?

ks129 commented 4 years ago

@sco1 i mean IGDB API . And yes, this will replace current game recommendation, but will add some more features

jb3 commented 4 years ago

The IGDB API key has been added through the environment variable IGDB_API_KEY.

jb3 commented 4 years ago

Does it have to replace the existing game stuff? Can we not extend the current system?

jb3 commented 4 years ago

Though I guess the current system is limited... PRing to add a new game is not super efficient.

sco1 commented 4 years ago

If there's a choice between a local JSON file and an API that can both accomplish nearly the same task I would rather tend towards an API solution, as our resource files are very rarely (if ever) updated beyond their state when initially merged into the codebase.

jb3 commented 4 years ago

True, in that case I'm willing to approve this.

jb3 commented 4 years ago

This shouldn't be too different from the movies command, the description seems fine so feel free to add this.