search

python-discord / sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development.
MIT License
242 stars 240 forks source link

Porting CustomHelpCommand from `bot` #470

Open purefunctor opened 4 years ago

purefunctor commented 4 years ago

Description

This proposes porting the CustomHelpCommand class from the server's Python Bot. This would mean either replacing the current implementation for SeasonalBot or extending it to fit the port.

Reasoning

Most command groups often make use of ctx.send_help like .snake or .cogs which don't utilize the help embeds. A common pattern that's used for this instead is to use ctx.invoke the help command explicitly like .caesarcipher. This would allow for the help responses for these command groups to be consistent with each other.

Proposed Implementation

The port should hopefully be a one-to-one copy of the original implementation, moving helper functions and adding a few adjustments for SeasonalBot.

Would you like to implement this yourself?

Xithrius commented 3 years ago

@PureFunctor are you still planning on implementing this, or do you think this is worthy of more discussion?

purefunctor commented 3 years ago

I can't say I can work on this for now; I suppose further discussion might be needed in terms of the implications towards complexity or feature parity with the other bot.

Xithrius commented 3 years ago

Thank you for the quick response. I hope everything works out in the end.

ChrisLovering commented 1 year ago

This is now being ported to bot-core so that both bots can use the same code.

shtlrs commented 1 year ago

I'll take care of this.