search

python-discord / sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development.
MIT License
246 stars 240 forks source link

Issues fetched by `.hacktoberissues` must have "hacktoberfest" topic in their repo #489

Open hedyhli opened 4 years ago

hedyhli commented 4 years ago

Description

hacktoberissues command returns issues, but the repo should also have "hacktoberfest" topic for it to count (and i don't really think a hacktoberfest label is needed but i may be wrong, please let me know)

with current logic, it finds issues with hacktoberfest label, without checking if the repo is even eligible

Possible Solutions

loop through results, only include those that has hacktoberfest topic

Would you like to implement a fix?

Note: For high-priority or critical bugs, fixes may be implemented by staff.

Anyone can implement the bug fix

ChrisGallardo commented 4 years ago

Yes, it's not just the hacktoberfest topic, but also PRs labeledhacktoberfest-accepted.

hedyhli commented 4 years ago

@ChrisGallardo @Den4200 i'm talking about fetching issues (.hacktoberissues) command, not PRs, so I don't think #475 fixes this, and I don't think hacktoberfest-accepted label on PRs is related. Am I missing something?

Den4200 commented 4 years ago

@hedythedev Right, sorry, I misread the issue.

ChrisGallardo commented 4 years ago

Oh I see.

Xithrius commented 3 years ago

@hedyhli Greetings. I seem to be around a year late to this, but would you still like to implement this fix?

hedyhli commented 3 years ago

@Xithrius I'm not sure I'll have the time, and I haven't worked with the codebase for quite a while so I might need some getting use to.

Also (for hacktoberfest stats/prs), this year's hacktoberfest (if it's happening) probably doesn't need the "first 3 days counts even if it doesn't haven hacktoberfest label" anymore. Again, I haven't been on discord for a long time nor have I seen the commits and stuff so I'm not sure if that needs to be changed before October.

In any case, I think we should let this issue be open to others, though if I'm lucky I might have time to have a look at it this weekend.

Xithrius commented 3 years ago

Alright, I'll leave it up for grabs for now.

hedyhli commented 3 years ago

I can work on this but it's blocked by #919 for now

hedyhli commented 3 years ago

After rethinking about it I decided it should include two types of issues:

  1. Python repo, has hacktoberfest as an issue label. Doesn't matter if it has hacktoberfest in the repo topics.
  2. Python repo, must have hacktoberfest in the issue's repo topics

This is because they accept PRs where the repo doesn't have the hacktoberfest topic but has the hacktoberfest-accepted label in the PR itself. If an issue has the hacktoberfest label (for type 1), maintainers would probably be willing to add the acceptance label if they don't have hackoberfest topic.