search

python-discord / sir-lancebot

A Discord bot started as a community project for Hacktoberfest 2018, later evolved to an introductory project for aspiring new developers starting out with open source development.
MIT License
242 stars 239 forks source link

Advent of code ends before December ends #992

Open onerandomusername opened 2 years ago

onerandomusername commented 2 years ago

Description

Taken on the 26th image

Steps to Reproduce

Look at the bot after AOC

Expected Behaviour

normal status or something

Actual Behaviour

countdown since aoc of the day that didn't happen

Known Impacted Platforms

Possible Solutions

More complex date checkers that can actually lock features to specific times of months, actually wouldn't be that hard to implement. @in_timeframe(start=..., end=...)

Or just have a checker in the event itself to check if its 1 to 25 or 26 to 31.

Would you like to implement a fix?

Note: For high-priority or critical bugs, fixes may be implemented by staff.

wookie184 commented 2 years ago

Looking at the current code it does seem to currently try and end at the right time https://github.com/python-discord/sir-lancebot/blob/532a8d53fca6c06a90d9bcb4862a36062750d359/bot/exts/events/advent_of_code/_helpers.py#L536-L539

Is the issue just that it isn't reset to what it originally was after this while loop?

onerandomusername commented 2 years ago

Is the issue just that it isn't reset to what it originally was after this while loop?

I think so, as someone restarted the deployment and the status reset.

wookie184 commented 2 years ago

Alright, that should be fairly simple to fix, just adding a line after the while loop to reset it. Would you like me to assign you?

Just need to think of a way of avoiding hardcoding the activity text across the two files, could have something like a get_default_activity function in bot/bot.py, or just put the text as a constant in constants.py, not sure.