search

python-discord / sir-robin

Our event bot, for managing community events.
MIT License
18 stars 14 forks source link

Fix f-strings, parenthesized expression whitespaces, and inf/nan #41

Closed thatbirdguythatuknownot closed 2 years ago

thatbirdguythatuknownot commented 2 years ago

…constants.

Fix the f-string output to follow PEP 9001. Fix parenthesized expressions by adding whitespace to the beginning and end of the expression. Fix inf/nan constants not appearing correctly.

Bluenix2 commented 2 years ago

What do we want to do with this PR (asking others in the events team and core developers)? The event is over already.

I believe the plan is to migrate this to sir-lancebot, so do we merge this first and then move forward with that?

minalike commented 2 years ago

I didn't announce the end of the event until April 4, so I think this PR is fair game to merge.

For other pending issues for blurplify perhaps they should be transferred to sir-lancebot and then stalled until the feature is ported.

ChrisLovering commented 2 years ago

once linting is sorted we can merge this PR

thatbirdguythatuknownot commented 2 years ago

once linting is sorted we can merge this PR

@ChrisLovering sorry for the long wait since I thought this PR was done, but the linting seems to be fine now.