search

python-discord / sir-robin

Our event bot, for managing community events.
MIT License
18 stars 14 forks source link

Add `cj add` command and `add_flow` to the CJ exts stack #57

Closed D0rs4n closed 2 years ago

D0rs4n commented 2 years ago

This PR introduces a new command and flow, which will enable the events team to add someone to the Code Jam either as a team lead or participant.

(Note: This add_flow is a modified version of the move_flow)

D0rs4n commented 2 years ago

Looks good, I think you've got a nice structure with the flows here. Looks pretty clean and somewhat nice "separation of concern" behaviour (I say somewhat because it still passes ctx).

I do have an inquiry though, what happens if there's already a leader and we want this member to be the leader? This may be a question for the codejam management system.

As of now, there is no Code Jam Management support for that, but I'll definitely write that one up on the list, since it's important to have management commands directed towards Code Jam Team leaders.