Closed janine9vn closed 1 year ago
I did not intend for my comments to block the merge (given that they were left with an approval). I don't know why GH is blocking. Feel free to resolve them whenever you want to merge this. I assume you're still waiting for env vars to be set in prod?
This is a migration of the Advent of Code cog, mostly as-is, from Sir Lancebot to Sir Robin. This is as close to a straight migration as I could manage. Any changes or improvements we want will be made in subsequent PRs once this is merged in.
How do I review this?
I've split this up into 4 commits, grouped by collections of files/changes:
utils/
filesconstants.py
fileThe commits have information about what is not quite the straight port. Spoiler alert: it's some import statements and parts of the Redis Cache. Everything else is a straight copy/paste or drag/drop.
If you'd like to test this with minimal effort, I can provide most of my
.env
file that includes the leaderboard session cookie information. I can also provide you access to my test server where it should have the roles and constants configured for my.env
file.