This corrects some permissions issues from last year:
Adds Sir Robin to individual team channels
Give the Event Lead roles manage_channels permission for the category
Adds Sir Lancebot and Python to team channels and the category overall, just to be sure
Why do we have to override permissions on the individual channels when it's being added to the category is a reasonable question you might ask when looking at this PR. The answer lies in the hell that is the Discord channel permission system. When creating a channel from a category, if you override the permissions during creation, it will not inherit the permissions from the category. We override the permissions on creation to add the individual team roles. So therefore we need to duplicate some efforts to make sure we cover our bases.
Also this change will ping teams in their team channels when we announce. This is a QoL change requested from last year that I went ahead and implemented since I had to edit the _views.py file anyway.
Also d.py changed the ordering of their arguments for the UI on_error function, so I had to correct that as well.
This corrects some permissions issues from last year:
Why do we have to override permissions on the individual channels when it's being added to the category is a reasonable question you might ask when looking at this PR. The answer lies in the hell that is the Discord channel permission system. When creating a channel from a category, if you override the permissions during creation, it will not inherit the permissions from the category. We override the permissions on creation to add the individual team roles. So therefore we need to duplicate some efforts to make sure we cover our bases.
Also this change will ping teams in their team channels when we announce. This is a QoL change requested from last year that I went ahead and implemented since I had to edit the
_views.pyfile anyway.Also d.py changed the ordering of their arguments for the UI
on_errorfunction, so I had to correct that as well.