search

python-discord / site

pythondiscord.com - A Django and Bulma web application.
https://pythondiscord.com
MIT License
639 stars 127 forks source link

Fix legacy Font Awesome icon classes #1255

Closed hedyhli closed 5 months ago

hedyhli commented 5 months ago

We were using some Font Awesome 4 classes, eg:

Which have since been removed. They don't show up correctly after switching to Font Awesome 6 (in #1232).

This is because the Kit we were previously using included some JS files that handled the backwards compatibility. (Thanks to @lemonsaurus for finding this out)

This fix replaces these font awesome classes to the most sensible replacements I could find, which are the new class names and should all display correctly.

Timeline

https://pythondiscord.com/timeline/ https://deploy-preview-1255--pydis-static.netlify.app/timeline/

1

image image

2

image image

Resources

https://pythondiscord.com/resources/?type=project-ideas https://deploy-preview-1255--pydis-static.netlify.app/resources/?type=project-ideas

image image

Code Jam results

https://www.pythondiscord.com/events/code-jams/ https://deploy-preview-1255--pydis-static.netlify.app/events/code-jams/

For CJ10, 9, 8.

image image

netlify[bot] commented 5 months ago

Deploy Preview for pydis-static ready!

Name Link
Latest commit f9ceeadd3be2d44f95dc3de8d5c3ec840a7c937b
Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/65f73dccd0631f0008858884
Deploy Preview https://deploy-preview-1255--pydis-static.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls commented 5 months ago

Coverage Status

coverage: 100.0%. remained the same when pulling f9ceeadd3be2d44f95dc3de8d5c3ec840a7c937b on fix/timeline-icons into 02098433ded28d9884efe10a1a3901f40371fb59 on main.

hedyhli commented 5 months ago

I noticed there are a few more FA icons on our site that needs fixing, from looking at a deploy preview from before #1232 the issue might be from upgrading FA, from which incompatible classes we might've missed.

I think I'll just fix those as well in this PR together since I found them already.

hedyhli commented 5 months ago

There's a one-liner fix for that which just changes hidden items from visibility: hidden to opacity: 0. Further testing might be needed though.

Xithrius commented 5 months ago

I'm bad at requesting reviews, apologies