A number of useful features were introduced that benefit us directly.
This means most, if not all...
limitations described in #1176 (on the CSS side),
warnings/tips documented in #1231, and
the hardcoded colors throughout the code base...
...are no longer necessary once we upgrade.
Note though, we're still blocked by lemonsaurus/django-simple-bulma#100 if we decide to do this.
Overview of the changes
For now, I can think of:
Adapting to whatever changes django-simple-bulma introduces in response to this.
Remove the dark variables in settings.py and make use of Bulma's built-in dark theme support with minimal customizations.
Remove rules that use [data-theme="dark"] throughout the site for ones that are covered by Bulma.
Use CSS Variables in place of hardcoded Bulma colors throughout the site.
Why?
The benefits of this are alike that of modularization and that of the best practices reviewers for our (other) Python projects tend to push for. The frontend becomes much, much easier to maintain and update in the long run and we'll now be relying less on "hacky" solutions to make something which Bulma previously did not support, work. Of course, the code also becomes much more readable.
Currently, there's not much we can do than wait, but I've opened this issue to start the conversation and receive some input regarding the possible migration to v1 after it's supported by django-simple-bulma.
Bulma v1.0.0 is here! 🎉 https://bulma.io/documentation/start/migrating-to-v1/
A number of useful features were introduced that benefit us directly.
This means most, if not all...
...are no longer necessary once we upgrade.
Note though, we're still blocked by lemonsaurus/django-simple-bulma#100 if we decide to do this.
Overview of the changes
For now, I can think of:
settings.pyand make use of Bulma's built-in dark theme support with minimal customizations.[data-theme="dark"]throughout the site for ones that are covered by Bulma.Why?
The benefits of this are alike that of modularization and that of the best practices reviewers for our (other) Python projects tend to push for. The frontend becomes much, much easier to maintain and update in the long run and we'll now be relying less on "hacky" solutions to make something which Bulma previously did not support, work. Of course, the code also becomes much more readable.
Currently, there's not much we can do than wait, but I've opened this issue to start the conversation and receive some input regarding the possible migration to v1 after it's supported by django-simple-bulma.