search

python-discord / site

pythondiscord.com - A Django and Bulma web application.
https://pythondiscord.com
MIT License
638 stars 127 forks source link

Use proper logos and better positioning in the footers #1268

Closed hedyhli closed 3 months ago

hedyhli commented 4 months ago

Closes #662, and as part of it, also closes #458.

Relevant #dev-contrib discussion: https://discord.com/channels/267624335836053506/635950537262759947/1220627130644434996

Changes

Footer logos and positioning:

netlify[bot] commented 4 months ago

Deploy Preview for pydis-static ready!

Name Link
Latest commit 88a0c2ebf178eced59bfdfc132ebc84785ecaf14
Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/66022bc9c13929000860a811
Deploy Preview https://deploy-preview-1268--pydis-static.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coveralls commented 4 months ago

Coverage Status

coverage: 100.0%. remained the same when pulling 88a0c2ebf178eced59bfdfc132ebc84785ecaf14 on fix/footer-logo-filtering into f3f78ed14bc7dabcf2aa745e5268df67cbbdb404 on main.

hedyhli commented 3 months ago

It should be alright in both windows and android now.

On iOS, it's pretty misaligned vertically if I zoom in, but it's probably somewhat subtle otherwise.

Since this isn't such a major issue (I've made sure no part of the image is cut off on all platforms) we'll just make sure it looks good for the majority of our users for now, as lemon suggested in the linked discussion. Considering that this is web dev, I wonder if a cross-platform solution even exists.

Descenders in Django and Netcup which is what caused the issue can't really be fixed without hardcoding the vertical offsets, but I've cropped the linode icon and switched to the text-only Bulma logo (both of which has no descenders) so it will show up aligned on all platforms.

hedyhli commented 3 months ago

Of course, wookie, I hacked into your computer to test it! ;P

But yes, since they're fairly small logos in the footer I don't think the offsets on iOS are that noticeable. We could see if anyone complains.