Use xargs over find -exec to ensure exit code is returned properly

python-discord / snekbox

Easy, safe evaluation of arbitrary Python code

https://pythondiscord.com

MIT License

213 stars 39 forks source link

Use xargs over find -exec to ensure exit code is returned properly #208

Closed ChrisLovering closed 8 months ago

ChrisLovering commented 8 months ago

Running this script in it's previous form (via docker compose run) always returned an exit code of 0. This is due to find always returning a 0 exit code, unless an error occurred while traversing the directories.

This caused CI to always report a success when isntalling deps, even when pip failed.

coveralls commented 8 months ago

coverage: 90.969%. remained the same when pulling 324f74f6726e047b2e292dc8033493294d3556c5 on update-eval-deps-script into 9cdcd286f185d6bed28929b79c579ca6a383f4a1 on main.

ChrisLovering commented 8 months ago

forcepush was to reword the commit description to be clearer.