search

python-distro / distro

A much more elaborate replacement for removed Python's `platform.linux_distribution()` method
https://distro.readthedocs.io/
Apache License 2.0
265 stars 66 forks source link

Restores compatibility shim with `platform.linux_distribution` #325

Closed HorlogeSkynet closed 2 years ago

HorlogeSkynet commented 2 years ago

230 introduced proper support for os-release VERSION_CODENAME attribute but broke compatibility shim with (now defunct) platform.linux_distribution as the third tuple member (codename) were not taken from VERSION os-release attribute anymore.

Closes #238.

EDIT : Sorry for first submission, wrong revision.

sethmlarson commented 2 years ago

Are we able to revert https://github.com/python-distro/distro/pull/230 first to ensure we're restoring compatibility and then evaluate what to do next?

hartwork commented 2 years ago

Are we able to revert #230 first to ensure we're restoring compatibility and then evaluate what to do next?

@sethmlarson it's pretty big and in for 2 years. I'm not sure I'd vote for that path. What's the idea?

HorlogeSkynet commented 2 years ago

Are we able to revert #230 first to ensure we're restoring compatibility and then evaluate what to do next?

I'm with @hartwork on this, #230 brings an important support and reverting it would change current distro behavior.