python-distro / distro

A much more elaborate replacement for removed Python's `platform.linux_distribution()` method
https://distro.readthedocs.io/
Apache License 2.0
265 stars 65 forks source link

Ignore the file '/etc/board-release' #353

Closed pedrolamas closed 1 year ago

pedrolamas commented 1 year ago

Adds board-release to ignored patterns, which is used by some Armbian based releases, such as the one used with the BigTreeTech CB1.

Full text search here: https://github.com/bigtreetech/CB1-Kernel/search?q=board-release

HorlogeSkynet commented 1 year ago

Hi @pedrolamas ! Many thanks for your PR, one comment though : could you provide a "testing" rootfs under tests/resources/distros/ too ? 🙂

pedrolamas commented 1 year ago

Thanks @HorlogeSkynet, I've now added a test for this specific case.

HorlogeSkynet commented 1 year ago

Thanks ! We'll have to wait for #355 and a proper rebase/merge of this branch 😉


EDIT : Ready for rebase 😇

pedrolamas commented 1 year ago

EDIT : Ready for rebase 😇

Rebased! 😁