Off-load pyinstaller config to its hook

python-eel / Eel

A little Python library for making simple Electron-like HTML/JS GUI apps

MIT License

6.44k stars 587 forks source link

Open samuelhwilliams opened 4 years ago

samuelhwilliams commented 4 years ago

PyInstaller now has a custom hook for Eel (https://github.com/pyinstaller/pyinstaller-hooks-contrib/pull/6) that tells it how to collect eel.js and our hidden imports (bottle-websocket), so we don't need our own code to enable this.

We can also define a 'distribution' extra for Eel to additionally install PyInstaller for the user.

NOTE: We need to wait for a release of PyInstaller that includes the new hook.

ChrisKnott commented 4 years ago

Strong change

samuelhwilliams commented 4 years ago

https://github.com/pyinstaller/pyinstaller/releases/tag/v4.0 has been released now - update Eel for PyInstaller v4 and merge this.