python-eel / Eel

A little Python library for making simple Electron-like HTML/JS GUI apps
MIT License
6.3k stars 580 forks source link

Is this project dead / abandoned ?? #600

Closed AmmarHaddadi closed 1 year ago

AmmarHaddadi commented 2 years ago

The owner is not updating the files even if people are still pushing good edits

ChrisKnott commented 2 years ago

I would say it's semi-abandonned. My life circumstances don't give me any time to work on it unfortunately.

If there is anyone, or a set of people, who want to take the project over I am happy to give them permissions to the repo.

The project's continued popularity took me by surprise. It makes me feel bad to constantly get email alerts that I can't look into :/

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Ammar Haddadi @.> Sent: Saturday, 23 July 2022, 12:39 To: ChrisKnott/Eel @.> Cc: Subscribed @.***> Subject: [ChrisKnott/Eel] Is this project dead / abandoned ?? (Issue #600)

The owner is not updating the files even if people are still pushing good edits

β€” Reply to this email directly, view it on GitHubhttps://github.com/ChrisKnott/Eel/issues/600, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHKLKULBPLRLOUCBAQAFVTVVPKYBANCNFSM54N4CKZQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

manecosta commented 1 year ago

I just found out about eel a couple of days ago and it's by far one of the most useful projects I've seen in a while. It is is too good of an idea to allow it to die. I really hope there's someone with enough knowledge on it that can keep moving it forward. I also hope your life changes in a positive way that allows you to dedicate some time to it again.

In the meantime, I'll keep experimenting with it and if I ever feel like I'm in a good position to lend a hand, I'll definitely propose myself. To everyone in the community that has a good grasp on it and has the will and time to devote, please do consider becoming a maintainer!

dstricks commented 1 year ago

I really like Eel and don't want to see it officially abandoned. I can help out on a limited basis. My only request is that @ChrisKnott provisionally agree to either a) package up and deploy out new releases to PyPI with new contributions I assist with OR b) eventually give me the permissions to do so. I wouldn't want any invested time to go to waste if no new releases are pushed out to the community.

If any bona fides are desired... I've answered several Eel tagged questions on Stack Overflow (https://stackoverflow.com/search?q=user:464504+eel&s=3c4736c0-4565-4005-b5e9-6b4e0024ceff). And I've been a full-time Python developer for many years (https://www.linkedin.com/in/dstricks).

dardevelin commented 1 year ago

I think becoming a maintainer of a branch at first and ramping up would be a good way to get the ball rolling.

Python is great that you can easily use a repo in pip pointing to a branch release. I certainly would be more comfortable that way, but it’s not like I have say on the matter.

On Mon 22. Aug 2022 at 01:40 dstricks @.***> wrote:

I really like Eel and don't want to see it officially abandoned. I can help out on a limited basis. My only request is that @ChrisKnott https://github.com/ChrisKnott provisionally agree to either a) package up and deploy out new releases to PyPI with new contributions I assist with OR b) eventually give me the permissions to do so. I wouldn't want any invested time to go to waste if no new releases are pushed out to the community.

If any bona fides are desired... I've answered several Eel tagged questions on Stack Overflow ( https://stackoverflow.com/search?q=user:464504+eel&s=3c4736c0-4565-4005-b5e9-6b4e0024ceff). And I've been a full-time Python developer for many years ( https://www.linkedin.com/in/dstricks).

β€” Reply to this email directly, view it on GitHub https://github.com/ChrisKnott/Eel/issues/600#issuecomment-1221661111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK32Y3K7EZ4RRBN24IEOOTV2LD6DANCNFSM54N4CKZQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

dstricks commented 1 year ago

I think becoming a maintainer of a branch at first and ramping up would be a good way to get the ball rolling.

TBH, I don't care about the mechanics of how the code gets released, only that someone agrees to release it. I'd be fine submitting PR's like the rest of the general public and not even having commit access so long as someone is there to merge and release. That's my main concern... doing things that nobody will use.

Python is great that you can easily use a repo in pip pointing to a branch release.

Pip is versatile for sure. If people are willing to install an unofficial version, then they could clone the code, make whatever updates they wanted, and then pip install <path-to-your-version> and they'd be good to go. Or install a fork (there are 500+ of them). But IMHO these options don't support the larger community... 50K downloads last month alone per https://pypistats.org/packages/eel.

samuelhwilliams commented 1 year ago

Hey @dstricks - just heard from Chris that you've offered to pick up maintaining Eel which is super exciting, thanks! Like Chris I feel bad seeing how active the community still is despite our lack of time to maintain the repo.

Happy to have a chat and hopefully get you setup and in a place where you can maintain Eel and release new versions :)

dstricks commented 1 year ago

Heya @samuelhwilliams, yeah it's true! Chris made me a collaborator recently and I've been trying to get up to speed. I'd appreciate any handover tips or advice you're willing to give. I'm very familiar with Python, but not so much maintaining open source on GitHub or publishing to PyPI, so that's where guidance would be very useful. I can be reached at dstricks@gmail.com or more recently dstricks#0510 on Discord.

At a minimum, I think either you or @ChrisKnott will need to add me to the PyPI project for when a new release is built and ready to be distributed. That may be a little while depending on how much I want to try to fit into a v0.15.0. Anyway, any guidance would be much appreciated. Cheers!

ChrisKnott commented 1 year ago

@dstricks Yep I will add you to PyPI and also transfer ownership of the repo (unless you think it's better to set up an "organisation" account?). Beware that you will probably start getting automated hacking attempts on your account so maybe set up 2FA or at least pick a strong password!

dstricks commented 1 year ago

I will add you to PyPI and also transfer ownership of the repo (unless you think it's better to set up an "organisation" account?).

I'm fine with taking ownership. To be honest... whatever is easiest for you so long as I can publish :)

Beware that you will probably start getting automated hacking attempts on your account so maybe set up 2FA or at least pick a strong password!

I think I have 2FA enabled, but I'll double-check that now! Thanks for the tip.

samuelhwilliams commented 1 year ago

You shouldn't need to be added to PyPi immediately or do anything custom - when you want to release a new version, run the 'Publish' github action in this repo and it should go straight out.

We can get you switched over on there eventually but it's not something that needs to happen immediately :)

samuelhwilliams commented 1 year ago

@dstricks Sounds exciting that you have lots planned for v0.15.0, but I would definitely recommend taking it slow in the beginning and publishing smaller more incremental updates just while you get your head around things - eg to get familiar with the publishing/versioning process, etc. Priority should obviously be to not break anything and to keep broadly following semver, ie don't mess too much with backwards compatibility without going to v1 (although v0.x generally doesn't indicate API stability, it's still nice to not mess around too much obviously).

dstricks commented 1 year ago

when you want to release a new version, run the 'Publish' github action in this repo and it should go straight out.

@samuelhwilliams That sounds brilliant! I see the Publish workflow, along with the previous runs that were successful for v0.14.0 and below, but there's no "Run Workflow" button for me that most github guidance suggests should be there. I'll keep poking around, but do you know if there are any permissions or similar that would need to be tweaked to enable that for me? It could totally be my lack of understanding of how these things work... there are so many bells and whistles enabled now :)

netesy commented 1 year ago

I believe an organisation account would be better.

samuelhwilliams commented 1 year ago

@netesy this is something @ChrisKnott and I were just discussing - yes, it may be.

dstricks commented 1 year ago

@ChrisKnott and @samuelhwilliams Could you kindly allow me to push to master OR alternatively provide Reviews on my PR's when they become stale after a few days? (I can add you guys as reviewers when they've been lingering for a few days).

One day I hope to have everything Reviewed by the community, but I don't think it's active enough yet. I've been waiting and hoping that someone would provide a review to #612 which was submitted two weeks ago, but no luck. And I just submitted another one with #616.

Let me know your thoughts on how to proceed in a safe but "less painful" manner.

Sounds exciting that you have lots planned for v0.15.0

Not at all :)

I'm super cautious. My only plan right now is to update all the core dependencies and try to add support and testing for 3.9 and 3.10. That'll most likely be reviewing #558. I might also pick up a few other items that looks straightforward and would be typical "first-time contributor" level things.

ChrisKnott commented 1 year ago

Yes I'm fine with that, can't find where the option is though...?

samuelhwilliams commented 1 year ago

@dstricks one thing I'd suggest is not pushing to master directly (as standard). Work on branches, push up a branch, make a PR, and merge it from there. Even if you're not getting review/approval from another developer it's good in terms of transparency, letting others see what features are coming in and why, and keeping changes self-contained.

It's a good habit to get in for open source projects, and I'd suggest only breaking this in absolute emergencies (of which I can't think of many, really).

Feel free to tag me in a couple of PRs but can't promise too much time. If I haven't reviewed within a couple of days (Mon-Fri), I'd say probably just go ahead on your own πŸ‘

samuelhwilliams commented 1 year ago

@dstricks I made a mistake when talking about how to publish new versions of Eel to PyPi. The workflow is set up to automatically publish when a release is made on GitHub. You can hopefully do that (now) from this page: https://github.com/python-eel/Eel/releases

Click 'Draft new release', then 'Choose a tag' and enter a new tag for the version (in format vX.Y.Z). Give the release a title and a description of the changes, then click Publish release. After doing that the Publish workflow will automatically kick off. Make sure that you've updated setup.py's version= to the matching version number first, and added an entry to the changelog (probably the same as the GitHub release description).

dstricks commented 1 year ago

Work on branches, push up a branch, make a PR, and merge it from there. Even if you're not getting review/approval from another developer it's good in terms of transparency, letting others see what features are coming in and why, and keeping changes self-contained.

That works for me. It could be my lack of understanding of how GitHub works, but I'm neither able to add a Review to my own PR nor merge a PR without 1 approved Review. So they get stuck :)

Long term if we can get active community support, then I don't want to merge any PR (even my own) without an approval. But I think it will take time for that to build.

you can hopefully do that (now) from this page

I'll check and confirm. Thanks for the update!

samuelhwilliams commented 1 year ago

That works for me. It could be my lack of understanding of how GitHub works, but I'm neither able to add a Review to my own PR nor merge a PR without 1 approved Review. So they get stuck :)

This was the case but shouldn't be any longer - I've disabled the "require approvals before merge" option :) You're right though: you can't post a review of your own PR (GitHub doesn't allow it).

It's definitely still nice to get reviews where possible though - but no longer blocking you if Chris or I aren't available.

netesy commented 1 year ago

I will be willing to contribute in anyway possible. Right now i am thinking about writing user tutorials/documentation for new users.

dstricks commented 1 year ago

I will be willing to contribute in anyway possible. Right now i am thinking about writing user tutorials/documentation for new users.

Nice, thanks @netesy. There are several "how can I..." type questions in the issues that could use attention, so that help would be much appreciated!

You can hopefully do that (now) from this page

I'm able to open the 'Draft a new release' page, so I assume so. We'll find out whenever I try to release :-)

I believe an organisation account would be better.

An organisation was formed!!!

@ChrisKnott and @samuelhwilliams IMHO the formation of the Python Eel organisation deserves an issue announcement. It shows the project is taking steps towards building a sustainable and collectively managed future and plans to be around long-term. I can make such an announcement if you think it's warranted but you don't have the time.

A few related questions:

samuelhwilliams commented 1 year ago

I can make such an announcement if you think it's warranted but you don't have the time.

By all means πŸ‘

Should we update the setup.py to have Python Eel information as author? Same question as above but for author_email (if there a Python Eel email address that can be used)?

Sounds like a good idea, yeah πŸ‘

What's your vision for the Python Eel organisation? I know the immediate term is to house Eel, but longer term do you have plans?

Broadly we've just formed the organisation in order to facilitate cleaner lines of management for Eel - so it's mostly an operational decision rather than one made with strategic goals in mind. I would be inclined to say that the community (including you as a new maintainer) should decide on the way forward, particularly as Chris and I haven't had the time to put towards setting these long-term goals and it's likely that any contribution or involvement we have in the near future will be fairly ad-hoc.

dstricks commented 1 year ago

Sounds like a good idea, yeah πŸ‘

@samuelhwilliams Did you create and/or register an organisation email that can be used in setup.py?

samuelhwilliams commented 1 year ago

@dstricks I haven't done that no - probably don't have a good option. Think we just make a gmail/protonmail account for it maybe?

dstricks commented 1 year ago

Think we just make a gmail/protonmail account for it maybe?

Yeah, good. If you want to set that up then just let me know the address. Or I can create it later this week and share the credentials with you and Chris. I have Chris' email because it was posted on PyPI, but I don't have yours. Mine is dstricks (at) Gmail if you want to reach out with yours.

I think it's time to close this issue :)

DvScripts commented 1 year ago

Think we just make a gmail/protonmail account for it maybe?

Yeah, good. If you want to set that up then just let me know the address. Or I can create it later this week and share the credentials with you and Chris. I have Chris' email because it was posted on PyPI, but I don't have yours. Mine is dstricks (at) Gmail if you want to reach out with yours.

I think it's time to close this issue :)

Maybe make official discord server to help people? ;-) and they could share ideas etc

dstricks commented 1 year ago

Hi @DvScripts, thanks for the suggestion. We do have one... here is an invite: https://discord.com/invite/3nqXPFX

The link is also in the project's README, but maybe not easy to quickly see.... might have to look into making it more prominent.