search

python-eel / Eel

A little Python library for making simple Electron-like HTML/JS GUI apps
MIT License
6.29k stars 582 forks source link

Fixed Tests #632

Closed doug-benn closed 1 year ago

doug-benn commented 1 year ago

I have fixed tests, is it pretty... no but they do run, I'm sure there are improvement that could be made!

Sorry for the number of commits and the bad names, I was just testing using the GitHub actions, but the actually changes are small ish.

Thanks

samuelhwilliams commented 1 year ago

Amazing work - the tests do indeed all seem to run and pass which is more than we've had for a long time 🎉

I do think we need to revisit some of this code and clean it up though. I'm particularly not fond of vendoring the binaries and would like to find a solution that doesn't require us to do that. 🤔

Could you squash the commits down into either: a set of logical separate commits, or just a single commit if there's not a sensible separation between them?

doug-benn commented 1 year ago

Hello,

Yes sorry for the mess, I should have fixed it!

The code is definitely a mess and very "hacky". Do you have any suggestion for testing without the binary? I'm not sure how else tests could be done on Eel

Thank you

doug-benn commented 1 year ago

What a mess! Sorry! I'm not even sure if I've done it or not? If it's no good I will make a new branch and start new PR