search

python-eel / Eel

A little Python library for making simple Electron-like HTML/JS GUI apps
MIT License
6.29k stars 582 forks source link

Fixed Tests v2 #651

Closed doug-benn closed 1 year ago

doug-benn commented 1 year ago

Hello,

Sorry I did a really bad job of the first PR so I am trying again,

Copy of the original comments #632 :

@samuelhwilliams

Amazing work - the tests do indeed all seem to run and pass which is more than we've had for a long time 🎉 I do think we need to revisit some of this code and clean it up though. I'm particularly not fond of vendoring the binaries and would like to find a solution that doesn't require us to do that. 🤔 Could you squash the commits down into either: a set of logical separate commits, or just a single commit if there's not a sensible separation between them?

The code is definitely a mess and very "hacky". Do you have any suggestion for testing without the binary? I'm not sure how else tests could be done on Eel

Thank you

doug-benn commented 1 year ago

Hello,

@samuelhwilliams Thank you for the feedback!

I have sorted out my lazy time.sleep(1) fix so be more robust now hopefully. I have also removed my formatting changes. Sorry about the commit history, I really can't work out how to shorten it down. I squashed them down and rebased it but they are all still showing on here. I think my inexperience is really showing with this messy PR

Thank you

samuelhwilliams commented 1 year ago

Thanks @doug-benn - this looks good, let's take it 👍

The tests haven't come through on here but they look good from the actions panel https://github.com/python-eel/Eel/actions/runs/3663716177

doug-benn commented 1 year ago

Thank you!