python-fedex-devs / python-fedex

A light wrapper around FedEx's SOAP API.
http://python-fedex.readthedocs.org
BSD 3-Clause "New" or "Revised" License
156 stars 139 forks source link

Update dependency to support suds-community #159

Closed ndobbs closed 2 years ago

ndobbs commented 2 years ago

This PR attempts to resolve issue #158

While building with the latest version of fedex our ci/cd process breaks while attempting to install the dependency suds-jurko.

ERROR: Command errored out with exit status 1:
     command: /usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-i40r_jb8/suds-jurko/setup.py'"'"'; __file__='"'"'/tmp/pip-install-i40r_jb8/suds-jurko/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-i40r_jb8/suds-jurko/pip-egg-info
         cwd: /tmp/pip-install-i40r_jb8/suds-jurko/
    Complete output (1 lines):
    error in suds-jurko setup command: use_2to3 is invalid.

Upon further examination it turns out that python's setuptools drops support for 2to3 in version v.58.0.0. In order to correct this it is recommended to switch to the new and actively maintained package suds-community which already has resolved this problem HERE.

Closes #158

I have also opted to pin this dependency for future cases where the project can be more intentional with the versions expected.

kokon commented 2 years ago

Any reasons why this is not merged?

CorainChicago commented 2 years ago

When will this change get released?

jpverdejo-FF commented 2 years ago

@radzhome Any chance we can get this change approved please? Thanks

alflanagan commented 2 years ago

Since #160 has been merged, this should also be closed, shouldn't it? It's now a duplicate.

jpverdejo-FF commented 2 years ago

160 was closed, not merged. Master branch is still using suds-jurko, so it's not a duplicate

CorainChicago commented 2 years ago

Thank you! When will the next version with this change in it get released?

ashtonpaul commented 3 months ago

Any update on the release?