python-gino / gino-starlette

An extension for GINO to support Starlette server.
https://python-gino.org
Other
78 stars 24 forks source link

[chore]: Update versions #26

Closed Chaostheorie closed 2 years ago

Chaostheorie commented 3 years ago

@wwwjfy This has to be tested and merged since ATM gino-starlette is not compatible with fastapi due to fastapi depending on starlette 0.16.

wwwjfy commented 3 years ago

test failed. need to check.

Chaostheorie commented 3 years ago

Yep, I'll try to take a look at it this evening.

Chaostheorie commented 3 years ago

yada yada, some problem with 3.6 and a sub-dependency. Will most likely need to be attached to a new release since it's a breaking change.

Chaostheorie commented 2 years ago

@wwwjfy is everything fine now? Checks are passing.

wwwjfy commented 2 years ago

test still fails. seems related to https://github.com/pytest-dev/pytest/issues/7114 need to take another look

wwwjfy commented 2 years ago

The above test failed because poetry.lock was not updated. (need to run poetry update after updating pyproject.toml)

There was another test failing because of Starlette TestClient's adoption of a library anyio. I disabled that test for the moment and may revisit it later.

Chaostheorie commented 2 years ago

Thank you for the fix and merge.