search

python-gino / gino-starlette

An extension for GINO to support Starlette server.
https://python-gino.org
Other
78 stars 24 forks source link

starlette version bound too tightly in pyproject.toml #37

Closed rambo closed 1 year ago

rambo commented 1 year ago

Expected Behavior

Can use gino-starlette with fresh FastAPI version (which depends on fresh starlette)

Actual Behavior

Dependency resolving fails

for "^0.19" the caret means that only 0.19.x patch versions are considered valid. This is different from "^1.2" where any 1.x version including and above 1.2 would be valid.

Steps to Reproduce the Problem

  1. make package depend on gino[starlette]
  2. try to depend on fastapi 0.88

to fix

Change https://github.com/python-gino/gino-starlette/blob/master/pyproject.toml#L26 to:

starlette = ">=0.22,<1.0"  # caret behaviour on 0.x is to lock to 0.x.*

While at it I would also change https://github.com/python-gino/gino-starlette/blob/master/pyproject.toml#L27 to:

gino = "^1.0"

so when 1.1 is released gino-starlette does not fail dependency resolution.