search

python-gino / gino-starlette

An extension for GINO to support Starlette server.
https://python-gino.org
Other
78 stars 24 forks source link

Failing to run with Alembic with FastAPI #5

Open nf1s opened 4 years ago

nf1s commented 4 years ago

Expected Behavior

I am trying to run the alembic make migrations and expected to succeed

Actual Behavior

exception is raised

Steps to Reproduce the Problem

  1. clone https://github.com/ahmednafies/fastapi_gino.git
  2. run make makemigrations
command
`alembic revision --autogenerate`

error
AttributeError: type object 'AsyncpgDBAPI' has no attribute 'connect'

Specifications

nf1s commented 4 years ago

@fantix: what do you think?

fantix commented 4 years ago

Did you fix this? I cannot reproduce:

fastapi_gino$ pipenv run alembic revision --autogenerate
Loading .env environment variables…
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.autogenerate.compare] Detected added table 'users'
INFO  [alembic.autogenerate.compare] Detected added index 'ix_users_id' on '['id']'
  Generating /private/tmp/fastapi_gino/alembic/versions/bed5859fd0ca_.py ...  done

fastapi_gino$ pipenv run make migrate
Loading .env environment variables…
alembic upgrade head
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade  -> bed5859fd0ca, empty message
nf1s commented 4 years ago

Still I have the same error.

Chaostheorie commented 3 years ago

Well this is stale. But I haven't been able to reproduce either, with the newest versions.