search

python-gino / gino-tornado

An extension for GINO to support Tornado server.
https://python-gino.org/
Other
3 stars 1 forks source link

help to gino-tornado #1

Open ppsirg opened 4 years ago

ppsirg commented 4 years ago

i would like to help with gino tonrado extension, actually, im doing a tdd example with tornado-gino https://github.com/ppsirg/gino-tornado/tree/master/examples/navigation-system

i would like to know that is required to maintain this extension

fantix commented 4 years ago

Any help would be awesome! Please feel free to either create a PR, or let me know if you want to be the maintainer of this repo - I can add you to the team.

ppsirg commented 4 years ago

i want to be maintainter of this repo, i use gino-tornado for many production applications, i just read about new version of gino and how this extension is without updates, so, i want to help to update this extension.

fantix commented 4 years ago

Permission added, thank you so much for your help! Please let me know if you have issues accessing the necessary functions.

ppsirg commented 4 years ago

just checked and everything seems to be ok, about maintaining this extension, is only run tests with new tornado and gino versions and check everything is ok?, it is allowed to add some functionalities? (for example, i did a little migrations app for gino that made us work better with gino at office)

fantix commented 4 years ago

Sure, please feel free to commit & push to the master branch. But if you want, I'd be glad to review your PRs too.

Pushing new tags will trigger auto-build + PyPI upload, you can release new versions in this way.

ppsirg commented 4 years ago

understood, i will focus on tests first, thanks a lot

ppsirg commented 4 years ago

just finished first example and its documentation, worked nice with GINO 1.0 and Tornado 6.0.4, should i change version or just make more tests, implement coverage and then change version?

also, how can i help to write information here? https://python-gino.org/docs/en/master/reference/extensions/tornado.html?

fantix commented 4 years ago

Thanks! I'll review this tomorrow. Please kindly create PRs to edit https://github.com/python-gino/gino/blob/master/docs/reference/extensions/tornado.rst for the document. If it's just examples, I wouldn't recommend bumping the version of the Python package.