search

python-greenlet / greenlet

Lightweight in-process concurrent programming
Other
1.63k stars 247 forks source link

Pre-release wheels for macOS have invalid ABI tag #369

Closed layday closed 9 months ago

layday commented 11 months ago

The macOS wheels for version 3.0.0rc3 uploaded to PyPI have an invalid ABI tag (universal2), which pip refuses to process. greenlet-3.0.0rc3-cp312-universal2-macosx_10_9_universal2.whl should be greenlet-3.0.0rc3-cp312-cp312-macosx_10_9_universal2.whl, and so on.

edgarrmondragon commented 11 months ago

I think the wheels for 3.0.0 have a similar problem:

- greenlet-3.0.0-cp312-universal2-macosx_10_9_universal2.whl
+ greenlet-3.0.0-cp312-cp312-macosx_10_9_universal2.whl
layday commented 11 months ago

Yes, these wheels are not installable.

tasansal commented 11 months ago

Just noticed this in our CI/CD on Azure DevOps.

It installs on Arm64 M1 Max, but on x86 Mac CI/CD, it fails because it can't find the candidate.

This is on production 3.0.0 that went live a few hours ago.

edgarrmondragon commented 11 months ago

I started a PR: https://github.com/python-greenlet/greenlet/pull/372

edgarrmondragon commented 9 months ago

I think the wheel tags were fixed by https://github.com/python-greenlet/greenlet/commit/4418940827246bfadccc256ecd3c1107a5c535a8 so this can probably be closed

jamadden commented 9 months ago

Everything looks correct to me in 3.0.2.

layday commented 8 months ago

The macOS 11.0 tag that is currently in use means that macOS wheels are no longer installable using pip depending on the version of the macOS SDK Python was built against, because the version of packaging that pip bundles is two years out of date and does not emit new-style macOS version tags (see https://github.com/pypa/packaging/issues/497). Upgrading packaging in pip is blocked on legacy version specifier removal (https://github.com/pypa/pip/issues/11715). Please use macosx_10_16_universal2 instead of macosx_11_0_universal2 if the earliest macOS version you support is indeed Big Sur.

jamadden commented 8 months ago

The earliest tested macOS is macOS 12 (Monterey).