python-gsoc / python-blogs

Python Software Foundation GSoC Blog Platform. This system was used until 2024 but is no longer maintained.
http://python-gsoc.org/
GNU Affero General Public License v3.0
41 stars 60 forks source link

GSoC 2019 Implementing python virtual environment on the project. pipenv #76

Closed Arinze1020 closed 5 years ago

Arinze1020 commented 5 years ago

I notice that the project didn't make use of python virtual env on the project,

it would make it easy for the installation of the requirement, txt

i would clearly install all the dependence using pipenv

propersam commented 5 years ago

yea, I think that is needed. I also had trouble with package dependencies issues when i tried to install requirements.txt file

propersam commented 5 years ago

are you working on it

Arinze1020 commented 5 years ago

Yes

On Sun, Mar 24, 2019, 12:33 AM Samuel Ameh notifications@github.com wrote:

are you working on it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/python-gsoc/python-blogs/issues/76#issuecomment-475913903, or mute the thread https://github.com/notifications/unsubscribe-auth/AgRO3Ki0ipAqLPVjH7qU_HkCaRP-Xhfnks5vZrnQgaJpZM4cFNNa .

dotgourav commented 5 years ago

It is a given in any Python project that the person working on it would use virtual environment. Here, also it is being used, it is just that it is not mentioned in the README.

But thank you for pointing it out. I can understand there might be people who would not know about virtual environments, so, the most that can be done here is documentation changes(Installation steps) to indicate use of virtual environment, be it using virtualenv, virtualenvwrapper, pyenv or pipenv.

Arinze1020 commented 5 years ago

Good day @Gouravchawla i have implemented the change on read me

botanicvelious commented 5 years ago

i dont see a pull request

Arinze1020 commented 5 years ago

Good day @botanicvelious i have made a pull request