hospital-wsgi: TypeError: addSkip() takes exactly 2 arguments (3 given)

python-hospital / hospital

Tools to diagnose Python projects (supervision, monitoring).

Other

40 stars 8 forks source link

hospital-wsgi: TypeError: addSkip() takes exactly 2 arguments (3 given) #78

Closed benoitbryon closed 9 years ago

benoitbryon commented 9 years ago

If healthchecks use unittest's "skip" feature and healthchecks are served using WSGI, then we get a Python exception like TypeError: addSkip() takes exactly 2 arguments (3 given).

benoitbryon commented 9 years ago

The reason is:

unittest.TestResult.addSkip() requires test and reason arguments: https://docs.python.org/2.7/library/unittest.html#unittest.TestResult.addSkip
whereas as of version 0.8.1 hospital.wsgi.TestResult.addSkip() only has test argument (reason is missing): https://github.com/python-hospital/hospital/blob/0.8.1/hospital/wsgi.py#L45

=> hospital.wsgi.TestResult.addSkip() must require both test and reason arguments.