get rid of command_line_params

python-hydro / pyro2

A framework for hydrodynamics explorations and prototyping

https://python-hydro.github.io/pyro2

BSD 3-Clause "New" or "Revised" License

305 stars 124 forks source link

get rid of command_line_params #257

Closed zingale closed 2 months ago

zingale commented 2 months ago

we don't need a separate RuntimeParameters method to parse a string, instead we can just do this in pyro_sim.py and then use the existing set_val method from a dict. This also allows us to simplify the confusing Pyro() interface.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.