add detection for Darwin and use 'libc++' if detected

python-hyper / brotlicffi

Python bindings to the Brotli compression library

MIT License

147 stars 27 forks source link

add detection for Darwin and use 'libc++' if detected #144

Closed motorcityadam closed 3 years ago

motorcityadam commented 5 years ago

Closes #143

mm-matthias commented 5 years ago

@Lukasa Can you please merge this? Without this PR brotlipy is effectively broken on mac.

motorcityadam commented 5 years ago

@mm-matthias Apparently so. The only reason I caught it was I recently got a shiny new MacBook with Mojave on it. A first-time, fresh install of the latest XCode revealed the issue.

mm-matthias commented 5 years ago

@adamjcook Yeah, for me it also happened after some upgrade to Mojave. I had to run something like xcode-select --install which probably upgraded XCode from 9 to 10 and then brotlipy stopped working.