search

python-hyper / brotlicffi

Python bindings to the Brotli compression library
MIT License
147 stars 27 forks source link

decompress method should accept a dictionary parameter #57

Closed bra-fsn closed 4 years ago

bra-fsn commented 7 years ago

Hi, It's very nice that the library supports specifying a custom dictionary to compress(), but it lacks the same option on decompress(), which makes it somewhat hard(er) to use. Please provide a dictionary parameter to that method.

KOLANICH commented 5 years ago

damn, almost 3 years have passed.

bra-fsn commented 5 years ago

Time flies in good company :)

sethmlarson commented 4 years ago

No longer needed now that 1.0.7 has dropped the dictionary functionality.

KOLANICH commented 4 years ago

They have a separate branch with dictionaries. They have claimed they have dropped the API because they have have not improved it enough to make it stable and keep forever. But big IMHO - an unstable API is better than no API at all.

sethmlarson commented 4 years ago

When the API is stable we can bring it back, I have no problem doing that. However if we build against the most recent Brotli libraries there is no dictionary functionality.