python-hyper / h2

HTTP/2 State-Machine based protocol implementation
https://h2.readthedocs.io/en/stable
MIT License
963 stars 151 forks source link

Remove twisted CI testing #1192

Closed pgjones closed 5 years ago

pgjones commented 5 years ago

This has been broken for a while (due to a Twisted update), and I've insufficient Twisted knowledge to fix it. I understand from @Lukasa that this can safely be removed.

I'll leave this open for at least a week in case someone else knows better.

alexwlchan commented 5 years ago

I have no Twisted knowledge either, so I can’t help on that front!

Is it worth leaving it as an item in the build matrix with “allow_failures” (see Travis docs), so we’ll remember it was once there and needs addressing, but without it turning all the builds red?

Or do we think it’s unlikely we’ll ever go back to fix it?

pgjones commented 5 years ago

@alexwlchan thanks, it is a good suggestion but I'm going to go ahead and merge as I think this is better tested by twisted and I therefore don't plan to fix.